impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From taras...@apache.org
Subject [11/18] incubator-impala git commit: IMPALA-3715: Include more info by default in Impala debug memz webpage
Date Thu, 14 Jul 2016 19:05:08 GMT
IMPALA-3715: Include more info by default in Impala debug memz webpage

Testing: ran locally and looked at memz page

Change-Id: I0d3f7de64ab321f3b9c41a119fb3d744b60c78d1
Reviewed-on: http://gerrit.cloudera.org:8080/3540
Tested-by: Internal Jenkins
Reviewed-by: Kathy Sun <kathy.sun@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/148c23a3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/148c23a3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/148c23a3

Branch: refs/heads/master
Commit: 148c23a3cc0c588fe85f3d933e92cba0c0a72323
Parents: 761c39c
Author: kathy.sun <kathy.sun@cloudera.com>
Authored: Wed Jun 29 16:53:22 2016 -0700
Committer: Taras Bobrovytsky <tarasbob@apache.org>
Committed: Thu Jul 14 19:04:44 2016 +0000

----------------------------------------------------------------------
 be/src/util/default-path-handlers.cc | 9 ++++-----
 www/memz.tmpl                        | 2 --
 2 files changed, 4 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/148c23a3/be/src/util/default-path-handlers.cc
----------------------------------------------------------------------
diff --git a/be/src/util/default-path-handlers.cc b/be/src/util/default-path-handlers.cc
index 706f31a..8954fcc 100644
--- a/be/src/util/default-path-handlers.cc
+++ b/be/src/util/default-path-handlers.cc
@@ -101,11 +101,10 @@ void MemUsageHandler(MemTracker* mem_tracker, const Webserver::ArgumentMap&
args
   Value overview(ss.str().c_str(), document->GetAllocator());
   document->AddMember("overview", overview, document->GetAllocator());
 
-  if (args.find("detailed") != args.end()) {
-    // Dump all mem trackers.
-    Value detailed(mem_tracker->LogUsage().c_str(), document->GetAllocator());
-    document->AddMember("detailed", detailed, document->GetAllocator());
-  }
+  // Dump all mem trackers.
+  Value detailed(mem_tracker->LogUsage().c_str(), document->GetAllocator());
+  document->AddMember("detailed", detailed, document->GetAllocator());
+
 }
 
 void impala::AddDefaultUrlCallbacks(

http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/148c23a3/www/memz.tmpl
----------------------------------------------------------------------
diff --git a/www/memz.tmpl b/www/memz.tmpl
index 629fe94..5b4636f 100644
--- a/www/memz.tmpl
+++ b/www/memz.tmpl
@@ -22,9 +22,7 @@ Memory consumption / limit: <strong>{{consumption}}</strong>
/ <strong>{{mem_lim
 <h3>tcmalloc</h2>
 <pre>{{overview}}</pre>
 
-{{?detailed}}
 <h3>Breakdown</h3>
 <pre>{{detailed}}</pre>
-{{/detailed}}
 
 {{> www/common-footer.tmpl }}


Mime
View raw message