impala-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tarmstr...@apache.org
Subject [1/2] incubator-impala git commit: IMPALA-3698: Fix Isilon permissions test
Date Thu, 23 Jun 2016 06:39:19 GMT
Repository: incubator-impala
Updated Branches:
  refs/heads/master a5ae2bfd8 -> 3dccb0125


IMPALA-3698: Fix Isilon permissions test

Isilon OneFS 8.0 introduces a regression where a
ConnectionRefusedException is thrown if the table directory permission
is set to 444. This patch fixes the problem by changing the table
directory permissions to 544 for Isilon in the read only table test.

Change-Id: Ie5ed082133ad3ca35a7f68fa4be118a0e59270b8
Reviewed-on: http://gerrit.cloudera.org:8080/3433
Reviewed-by: David Knupp <dknupp@cloudera.com>
Tested-by: Taras Bobrovytsky <tbobrovytsky@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/3dccb012
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/3dccb012
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/3dccb012

Branch: refs/heads/master
Commit: 3dccb01257af8c59dc55feb819ed80f3539c386d
Parents: 7e4aacd
Author: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Authored: Tue Jun 21 16:27:19 2016 -0700
Committer: Tim Armstrong <tarmstrong@cloudera.com>
Committed: Wed Jun 22 23:39:12 2016 -0700

----------------------------------------------------------------------
 tests/metadata/test_hdfs_permissions.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/3dccb012/tests/metadata/test_hdfs_permissions.py
----------------------------------------------------------------------
diff --git a/tests/metadata/test_hdfs_permissions.py b/tests/metadata/test_hdfs_permissions.py
index 05a6ac4..75aac50 100644
--- a/tests/metadata/test_hdfs_permissions.py
+++ b/tests/metadata/test_hdfs_permissions.py
@@ -19,7 +19,7 @@ from tests.common.test_vector import *
 from tests.common.impala_test_suite import *
 from tests.common.test_dimensions import create_exec_option_dimension
 from tests.common.skip import SkipIfS3, SkipIfLocal
-from tests.util.filesystem_utils import WAREHOUSE
+from tests.util.filesystem_utils import IS_ISILON, WAREHOUSE
 
 TEST_TBL = 'read_only_tbl'
 TBL_LOC = '%s/%s' % (WAREHOUSE, TEST_TBL)
@@ -49,8 +49,12 @@ class TestHdfsPermissions(ImpalaTestSuite):
     self.hdfs_client.delete_file_dir('test-warehouse/%s' % TEST_TBL, recursive=True)
 
   def test_insert_into_read_only_table(self, vector):
+    permission = 444
+    if IS_ISILON:
+      # In Isilon OneFS 8.0, a change was introduced that requires this. See IMPALA-3698.
+      permission = 544
     # Create a directory that is read-only
-    self.hdfs_client.make_dir('test-warehouse/%s' % TEST_TBL, permission=444)
+    self.hdfs_client.make_dir('test-warehouse/%s' % TEST_TBL, permission=permission)
     self.client.execute("create external table %s (i int) location '%s'"
         % (TEST_TBL, TBL_LOC))
     try:


Mime
View raw message