Return-Path: X-Original-To: apmail-impala-commits-archive@minotaur.apache.org Delivered-To: apmail-impala-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5E55219051 for ; Tue, 12 Apr 2016 21:18:44 +0000 (UTC) Received: (qmail 76492 invoked by uid 500); 12 Apr 2016 21:18:44 -0000 Delivered-To: apmail-impala-commits-archive@impala.apache.org Received: (qmail 76467 invoked by uid 500); 12 Apr 2016 21:18:44 -0000 Mailing-List: contact commits-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list commits@impala.incubator.apache.org Received: (qmail 76458 invoked by uid 99); 12 Apr 2016 21:18:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2016 21:18:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C02B41801DA for ; Tue, 12 Apr 2016 21:18:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.221 X-Spam-Level: X-Spam-Status: No, score=-3.221 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id NO26GyqYYHrT for ; Tue, 12 Apr 2016 21:18:41 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id EE31660FA7 for ; Tue, 12 Apr 2016 21:18:37 +0000 (UTC) Received: (qmail 74437 invoked by uid 99); 12 Apr 2016 21:18:36 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Apr 2016 21:18:36 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 91F67E0615; Tue, 12 Apr 2016 21:18:36 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: tarmstrong@apache.org To: commits@impala.incubator.apache.org Date: Tue, 12 Apr 2016 21:19:12 -0000 Message-Id: <11fab8352778417d98f202c042c4fdab@git.apache.org> In-Reply-To: <412ef27135be438f9dae79ef8cd34525@git.apache.org> References: <412ef27135be438f9dae79ef8cd34525@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [38/50] incubator-impala git commit: IMPALA-3285: Fix ASAN failure in webserver-test IMPALA-3285: Fix ASAN failure in webserver-test This patch fixes a test ASAN issue where a RapidJson value was 'moved', rather than copied, into a Document object; the original was the deleted and the moved version became invalid. Change-Id: Ib0c71163af14c6f18e785938712caf193a393794 Reviewed-on: http://gerrit.cloudera.org:8080/2737 Reviewed-by: Alex Behm Tested-by: Internal Jenkins Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/b085e31f Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/b085e31f Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/b085e31f Branch: refs/heads/master Commit: b085e31ff415e5eea56fa7dc6d35b508ed313e7c Parents: 9bb1b8a Author: Henry Robinson Authored: Fri Apr 8 13:10:40 2016 -0700 Committer: Tim Armstrong Committed: Tue Apr 12 14:03:43 2016 -0700 ---------------------------------------------------------------------- be/src/util/webserver-test.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/b085e31f/be/src/util/webserver-test.cc ---------------------------------------------------------------------- diff --git a/be/src/util/webserver-test.cc b/be/src/util/webserver-test.cc index 392334b..094587c 100644 --- a/be/src/util/webserver-test.cc +++ b/be/src/util/webserver-test.cc @@ -289,8 +289,9 @@ TEST(Webserver, DirectoryListingDisabledTest) { } void FrameCallback(const Webserver::ArgumentMap& args, Document* document) { - const string& contents = ""; - document->AddMember("contents", contents.c_str(), document->GetAllocator()); + const string contents = ""; + Value value(contents.c_str(), document->GetAllocator()); + document->AddMember("contents", value, document->GetAllocator()); } TEST(Webserver, NoFrameEmbeddingTest) {