Return-Path: <user-return-8064-archive-asf-public=cust-asf.ponee.io@ignite.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 48FF2200BB1
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  3 Nov 2016 15:39:25 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 47B25160B0B; Thu,  3 Nov 2016 14:39:25 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 8D4F0160AFE
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  3 Nov 2016 15:39:24 +0100 (CET)
Received: (qmail 40766 invoked by uid 500); 3 Nov 2016 14:39:23 -0000
Mailing-List: contact user-help@ignite.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:user-help@ignite.apache.org>
List-Unsubscribe: <mailto:user-unsubscribe@ignite.apache.org>
List-Post: <mailto:user@ignite.apache.org>
List-Id: <user.ignite.apache.org>
Reply-To: user@ignite.apache.org
Delivered-To: mailing list user@ignite.apache.org
Received: (qmail 40757 invoked by uid 99); 3 Nov 2016 14:39:23 -0000
Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2016 14:39:23 +0000
Received: from mail-yb0-f181.google.com (mail-yb0-f181.google.com [209.85.213.181])
	by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 2C46E1A0046
	for <user@ignite.apache.org>; Thu,  3 Nov 2016 14:39:23 +0000 (UTC)
Received: by mail-yb0-f181.google.com with SMTP id f97so17685957ybi.1
        for <user@ignite.apache.org>; Thu, 03 Nov 2016 07:39:23 -0700 (PDT)
X-Gm-Message-State: ABUngvdlR2HEn40C/ENERpNgsXwLzj5mXJ5SGUVlHlfuvEcAa+/EN5kueWGU1dzBrSksvySpSkKG6slQnyhwTA==
X-Received: by 10.37.17.196 with SMTP id 187mr7256148ybr.56.1478183962476;
 Thu, 03 Nov 2016 07:39:22 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.37.171.134 with HTTP; Thu, 3 Nov 2016 07:39:22 -0700 (PDT)
In-Reply-To: <CALPm_-CjQaLT0QMpzdF-omhAEXnUy9xxb+75x5yYAV369Nc7wQ@mail.gmail.com>
References: <CALPm_-CjQaLT0QMpzdF-omhAEXnUy9xxb+75x5yYAV369Nc7wQ@mail.gmail.com>
From: Andrey Gura <agura@apache.org>
Date: Thu, 3 Nov 2016 17:39:22 +0300
X-Gmail-Original-Message-ID: <CAK1mX7EEa5f2NurFxN9WGvuGgTHqp-sh0PPue8P=7VJc3xwYkg@mail.gmail.com>
Message-ID: <CAK1mX7EEa5f2NurFxN9WGvuGgTHqp-sh0PPue8P=7VJc3xwYkg@mail.gmail.com>
Subject: Re: Null column values - bug
To: user@ignite.apache.org
Content-Type: multipart/alternative; boundary=001a113e67feffaf010540668506
archived-at: Thu, 03 Nov 2016 14:39:25 -0000

--001a113e67feffaf010540668506
Content-Type: text/plain; charset=UTF-8

String.valuOf(null) return "null" string by contract.

On Thu, Nov 3, 2016 at 5:33 PM, Anil <anilklce@gmail.com> wrote:

> HI ,
>
> null values are returned as "null" with ignite jdbc result set.
>
>  private <T> T getTypedValue(int colIdx, Class<T> cls) throws SQLException
> {
>         ensureNotClosed();
>         ensureHasCurrentRow();
>
>         try {
>             T val = cls == String.class ? (T)String.valueOf(curr.get(colIdx
> - 1)) : (T)curr.get(colIdx - 1);
>
>             wasNull = val == null;
>
>             return val;
>         }
>         catch (IndexOutOfBoundsException ignored) {
>             throw new SQLException("Invalid column index: " + colIdx);
>         }
>         catch (ClassCastException ignored) {
>             throw new SQLException("Value is an not instance of " +
> cls.getName());
>         }
>     }
>
>
> if a column value is null (curr.get(colIdx - 1) return null but
> String.valueOf( (curr.get(colIdx - 1) ) is not null it is "null".
>
> ArrayList<String> obj = new ArrayList<String>();
>                           obj.add(null);
> System.out.println(null == (String)String.valueOf(obj.get(0)));
>
> above Sysout is false.
>
> Fix :
>
> Object colValue = curr.get(colIdx - 1);
>
> T val = cls == String.class ? (String) colValue : (T) colValue;
>
> or return (T) colValue
>
>
> please let me know if you see any issues. thanks
>
>
>

--001a113e67feffaf010540668506
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">String.valuOf(null) return &quot;null&quot; string by cont=
ract.<br></div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On=
 Thu, Nov 3, 2016 at 5:33 PM, Anil <span dir=3D"ltr">&lt;<a href=3D"mailto:=
anilklce@gmail.com" target=3D"_blank">anilklce@gmail.com</a>&gt;</span> wro=
te:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-=
left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">HI ,<div><br></div><=
div>null values are returned as &quot;null&quot; with ignite jdbc result se=
t.</div><div><br></div><div><div><div>=C2=A0private &lt;T&gt; T getTypedVal=
ue(int colIdx, Class&lt;T&gt; cls) throws SQLException {</div><div>=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 ensureNotClosed();</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 ensureHasCurrentRow();</div><div><br></div><div>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 try {</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 T val =3D =
cls =3D=3D String.class ? (T)String.valueOf(curr.get(<wbr>colIdx - 1)) : (T=
)curr.get(colIdx - 1);</div><div><br></div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 wasNull =3D val =3D=3D null;</div><div><br></div><div>=C2=A0=
 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return val;</div><div>=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 }</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 catch (IndexOutOfBoundsE=
xception ignored) {</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 thr=
ow new SQLException(&quot;Invalid column index: &quot; + colIdx);</div><div=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 }</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 catch =
(ClassCastException ignored) {</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 throw new SQLException(&quot;Value is an not instance of &quot; + c=
ls.getName());</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 }</div><div>=C2=A0 =C2=
=A0 }</div></div><div><br></div><div><br></div><div>if a column value is nu=
ll (curr.get(colIdx - 1) return null but String.valueOf( (curr.get(colIdx -=
 1) ) is not null it is &quot;null&quot;.</div><div><br></div><div>ArrayLis=
t&lt;String&gt; obj =3D new ArrayList&lt;String&gt;();<br></div><div><div>=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 obj.add(null);</div><div>System.out.println(null =3D=3D (=
String)String.valueOf(obj.<wbr>get(0)));</div></div></div><div><br></div><d=
iv>above Sysout is false.=C2=A0</div><div><br></div><div>Fix :</div><div><b=
r></div><div>Object colValue =3D curr.get(colIdx - 1);<br></div><div><br></=
div><div>T val =3D cls =3D=3D String.class ? (String) colValue : (T) colVal=
ue;<br></div><div><br></div><div>or return (T) colValue</div><div><br></div=
><div><br></div><div>please let me know if you see any issues. thanks</div>=
<div><br></div><div><br></div></div>
</blockquote></div><br></div>

--001a113e67feffaf010540668506--