ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite-3] sanpwc commented on a change in pull request #321: IGNITE-15288 Fully implement RaftGroupService
Date Wed, 08 Sep 2021 03:37:32 GMT

sanpwc commented on a change in pull request #321:
URL: https://github.com/apache/ignite-3/pull/321#discussion_r703999506



##########
File path: modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java
##########
@@ -89,8 +89,9 @@ public Loza(ClusterService clusterNetSvc, Path dataPath) {
 
         String locNodeName = clusterNetSvc.topologyService().localMember().name();
 
-        if (nodes.stream().map(ClusterNode::name).collect(Collectors.toSet()).contains(locNodeName))
+        if (nodes.stream().map(ClusterNode::name).collect(Collectors.toSet()).contains(locNodeName))
{

Review comment:
       According to our code style we shouldn't use {} for one-liners. It's also strange that
inspections didn't cache this - could you please check this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message