ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] samaitra commented on issue #6490: IGNITE-7285 Add default query timeout
Date Thu, 07 Nov 2019 04:55:42 GMT
samaitra commented on issue #6490: IGNITE-7285 Add default query timeout
URL: https://github.com/apache/ignite/pull/6490#issuecomment-550754365
 
 
   > > @pavlukhin Thank you for reviewing and sharing feedback.
   > > If you note the tests in IgniteCacheDistributedQueryStopOnCancelOrTimeoutSelfTest
also, it is similar to Default Query timeout tests. I suppose the reason being we are throwing
QueryCancelledException for either manual cancel or query being cancelled due to timeout.
I agree throwing a separate exception for timeout vs manual cancel will be better approach
to handle different scenarios and help with logging and exception handling.
   > > I am also thinking if that change can be taken up as separate issue and we can
close on default query handling change in this PR.
   > 
   > @samaitra I can imagine checking exception message (to check that it is timeout) and
approximate cancellation time (to check that it was _default_ timeout). What do you think
of it?
   
   @pavlukhin I looked into the QueryCancelledException class and it has a generic message
as "The query was cancelled while executing.". Also my understanding is it is used commonly
for both manually cancelled exception cases and also for timeout exception cases. 
   
   We can consider creating  a separate exception when query is cancelled for timeout vs manually
cancelled but I think that change can be taken up in separate jira issue and PR considering
the scope.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message