From notifications-return-7701-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Oct 31 16:41:53 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6725718069C for ; Thu, 31 Oct 2019 17:41:52 +0100 (CET) Received: (qmail 84651 invoked by uid 500); 31 Oct 2019 16:41:51 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 84448 invoked by uid 99); 31 Oct 2019 16:41:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Oct 2019 16:41:51 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6554: IGNITE-11073: Backup page store manager, initial Message-ID: <157254011145.25787.7276715392535262211.gitbox@gitbox.apache.org> Date: Thu, 31 Oct 2019 16:41:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit alex-plekhanov commented on a change in pull request #6554: IGNITE-11073: Backup page store manager, initial URL: https://github.com/apache/ignite/pull/6554#discussion_r341164441 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/file/FilePageStore.java ########## @@ -386,6 +407,22 @@ private long checkFile(FileIO fileIO, File cfgFile) throws IOException { @Override public void finishRecover() throws StorageException { lock.writeLock().lock(); + try { Review comment: As far as I understand it's just refactoring? There are no usages of the new method and it's not related to the ticket, let's keep it as is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services