From notifications-return-7647-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Oct 30 09:07:23 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id F08CF180654 for ; Wed, 30 Oct 2019 10:07:22 +0100 (CET) Received: (qmail 33960 invoked by uid 500); 30 Oct 2019 09:07:22 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 33942 invoked by uid 99); 30 Oct 2019 09:07:22 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Oct 2019 09:07:22 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] pavlukhin commented on a change in pull request #6900: IGNITE-11312: Fix JDBC Driver properties in UI tools like DBeaver Message-ID: <157242644211.31604.4327760882471978408.gitbox@gitbox.apache.org> Date: Wed, 30 Oct 2019 09:07:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit pavlukhin commented on a change in pull request #6900: IGNITE-11312: Fix JDBC Driver properties in UI tools like DBeaver URL: https://github.com/apache/ignite/pull/6900#discussion_r340493524 ########## File path: modules/core/src/test/java/org/apache/ignite/internal/jdbc/thin/ConnectionPropertiesTest.java ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.jdbc.thin; + +import java.sql.DriverPropertyInfo; +import java.sql.SQLException; +import java.util.Properties; +import org.junit.Test; + +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertTrue; + +/** + * {@link ConnectionPropertiesImpl} unit tests. + */ +public class ConnectionPropertiesTest { + Review comment: Redundant empty line according to our code-style (automated checks on TeamCity will report that problem). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services