From notifications-return-7635-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Oct 29 07:36:44 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2DAC01804BB for ; Tue, 29 Oct 2019 08:36:44 +0100 (CET) Received: (qmail 50114 invoked by uid 500); 29 Oct 2019 07:36:43 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 50105 invoked by uid 99); 29 Oct 2019 07:36:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Oct 2019 07:36:43 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] dgarus commented on a change in pull request #6990: IGNITE-11992 The visor tasks lost permission. Message-ID: <157233460340.19145.10365016846487997169.gitbox@gitbox.apache.org> Date: Tue, 29 Oct 2019 07:36:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dgarus commented on a change in pull request #6990: IGNITE-11992 The visor tasks lost permission. URL: https://github.com/apache/ignite/pull/6990#discussion_r337384887 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java ########## @@ -275,8 +275,10 @@ if (secCtx0 == null || ses.isTokenExpired(sesTokTtl)) ses.secCtx = secCtx0 = authenticate(req, ses); - try(OperationSecurityContext s = ctx.security().withContext(secCtx0)) { + try (OperationSecurityContext s = ctx.security().withContext(secCtx0)) { authorize(req); + + return handle(req, true); Review comment: I think it's ok to call the handle method here, but more readable would move the second call into else block. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services