From notifications-return-7546-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Oct 23 14:22:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 60D2F180671 for ; Wed, 23 Oct 2019 16:22:29 +0200 (CEST) Received: (qmail 12073 invoked by uid 500); 23 Oct 2019 14:22:08 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 12024 invoked by uid 99); 23 Oct 2019 14:22:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Oct 2019 14:22:08 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] nizhikov commented on a change in pull request #6937: IGNITE-12186 TDE - Phase-2. Master key rotation. Message-ID: <157184052767.24381.10674136611446029886.gitbox@gitbox.apache.org> Date: Wed, 23 Oct 2019 14:22:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nizhikov commented on a change in pull request #6937: IGNITE-12186 TDE - Phase-2. Master key rotation. URL: https://github.com/apache/ignite/pull/6937#discussion_r338079236 ########## File path: modules/core/src/main/java/org/apache/ignite/spi/encryption/keystore/KeystoreEncryptionSpi.java ########## @@ -113,24 +113,13 @@ */ private int keySize = DEFAULT_KEY_SIZE; - /** - * Master key name. - */ - private String masterKeyName = DEFAULT_MASTER_KEY_NAME; - - /** - * Master key. - */ - private KeystoreEncryptionKey masterKey; + /** Tuple of the master key id and the master key. */ + private volatile T2 masterKey = new T2<>(DEFAULT_MASTER_KEY_NAME, null); Review comment: Not clear to me. Why do we need volatile guarantees here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services