From notifications-return-7526-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Oct 22 15:51:11 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1EFE218062C for ; Tue, 22 Oct 2019 17:51:11 +0200 (CEST) Received: (qmail 95647 invoked by uid 500); 22 Oct 2019 15:51:10 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 95638 invoked by uid 99); 22 Oct 2019 15:51:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Oct 2019 15:51:10 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] ptupitsyn commented on a change in pull request #6490: IGNITE-7285 Add default query timeout Message-ID: <157175947045.14765.4948968258838058425.gitbox@gitbox.apache.org> Date: Tue, 22 Oct 2019 15:51:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ptupitsyn commented on a change in pull request #6490: IGNITE-7285 Add default query timeout URL: https://github.com/apache/ignite/pull/6490#discussion_r337601883 ########## File path: modules/platforms/dotnet/Apache.Ignite.Core/IgniteConfiguration.cs ########## @@ -72,6 +72,11 @@ public class IgniteConfiguration /// public const int DefaultJvmMaxMem = -1; + /// + /// Default query timeout. + /// + public static readonly TimeSpan DefaultQueryTimeout = TimeSpan.FromMilliseconds(0); Review comment: Same name as the property below - won't compile. When the property is `X`, default value for it is `DefaultX`, so in this case it would be `DefaultDefaultQueryTimeout`. But since it is just `default(TimeSpan)`, I would remove it altogether. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services