From notifications-return-7354-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Sat Oct 12 11:56:28 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 78CC9180658 for ; Sat, 12 Oct 2019 13:56:28 +0200 (CEST) Received: (qmail 40674 invoked by uid 500); 12 Oct 2019 11:56:27 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 40648 invoked by uid 99); 12 Oct 2019 11:56:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Oct 2019 11:56:27 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] ascherbakoff commented on a change in pull request #6942: IGNITE-9913 Message-ID: <157088138775.14647.16972010886370239386.gitbox@gitbox.apache.org> Date: Sat, 12 Oct 2019 11:56:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ascherbakoff commented on a change in pull request #6942: IGNITE-9913 URL: https://github.com/apache/ignite/pull/6942#discussion_r334233883 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java ########## @@ -3839,7 +3969,14 @@ private void finalizePartitionCounters() { cctx.kernalContext().getSystemExecutorService(), nonLocalCacheGroups(), grp -> { - grp.topology().finalizeUpdateCounters(); + AffinityTopologyVersion topVer = sharedContext().exchange().readyAffinityVersion(); + + // Failed node's primary partitions or just all local backups in case of possible exchange merge. + Set parts = nodeId != null ? Review comment: It this intended as an optimization ? This is not really needed, because here all possible updates are received and all remaining gaps could be safely removed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services