From notifications-return-7341-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Fri Oct 11 10:00:29 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 08F5B180656 for ; Fri, 11 Oct 2019 12:00:28 +0200 (CEST) Received: (qmail 6112 invoked by uid 500); 11 Oct 2019 10:00:28 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 6103 invoked by uid 99); 11 Oct 2019 10:00:28 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Oct 2019 10:00:28 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] dgarus commented on a change in pull request #6904: IGNITE-12220 Message-ID: <157078802832.6315.14006008084581786464.gitbox@gitbox.apache.org> Date: Fri, 11 Oct 2019 10:00:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dgarus commented on a change in pull request #6904: IGNITE-12220 URL: https://github.com/apache/ignite/pull/6904#discussion_r333917598 ########## File path: modules/core/src/test/java/org/apache/ignite/internal/processors/security/cache/CacheOperationPermissionCheckTest.java ########## @@ -31,43 +32,108 @@ import org.junit.runners.JUnit4; import static java.util.Collections.singletonMap; +import static org.apache.ignite.plugin.security.SecurityPermission.CACHE_CREATE; +import static org.apache.ignite.plugin.security.SecurityPermission.CACHE_DESTROY; import static org.apache.ignite.plugin.security.SecurityPermission.CACHE_PUT; import static org.apache.ignite.plugin.security.SecurityPermission.CACHE_READ; import static org.apache.ignite.plugin.security.SecurityPermission.CACHE_REMOVE; +import static org.apache.ignite.plugin.security.SecurityPermission.JOIN_AS_SERVER; import static org.apache.ignite.testframework.GridTestUtils.assertThrowsWithCause; /** * Test CRUD cache permissions. */ @RunWith(JUnit4.class) public class CacheOperationPermissionCheckTest extends AbstractCacheOperationPermissionCheckTest { Review comment: I think you shouldn't mix system tests with crud tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services