From notifications-return-7290-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Oct 9 13:50:24 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 633A5180658 for ; Wed, 9 Oct 2019 15:50:24 +0200 (CEST) Received: (qmail 49097 invoked by uid 500); 9 Oct 2019 13:42:18 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 48943 invoked by uid 99); 9 Oct 2019 13:42:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Oct 2019 13:42:17 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] agoncharuk commented on a change in pull request #6942: IGNITE-9913 Message-ID: <157062853558.29044.1144051756134517774.gitbox@gitbox.apache.org> Date: Wed, 09 Oct 2019 13:42:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit agoncharuk commented on a change in pull request #6942: IGNITE-9913 URL: https://github.com/apache/ignite/pull/6942#discussion_r333019827 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java ########## @@ -1628,6 +1660,100 @@ private void changeWalModeIfNeeded() { return null; } + /** + * @throws IgniteCheckedException If failed. + */ + private void waitRecovery() throws IgniteCheckedException { Review comment: The code in this method is very much similar to the waitPartitionRelease(). Can we avoid the duplication? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services