From notifications-return-7194-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Oct 3 14:37:21 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 31B6618069C for ; Thu, 3 Oct 2019 16:37:21 +0200 (CEST) Received: (qmail 11883 invoked by uid 500); 3 Oct 2019 14:37:20 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 11824 invoked by uid 99); 3 Oct 2019 14:37:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Oct 2019 14:37:20 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] AMashenkov commented on a change in pull request #6917: IGNITE-12189 Implementation correct limit for TextQuery Message-ID: <157011344038.7671.3999285764220199806.gitbox@gitbox.apache.org> Date: Thu, 03 Oct 2019 14:37:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit AMashenkov commented on a change in pull request #6917: IGNITE-12189 Implementation correct limit for TextQuery URL: https://github.com/apache/ignite/pull/6917#discussion_r331070480 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/platform/cache/PlatformCache.java ########## @@ -1420,9 +1420,10 @@ private Query readTextQuery(BinaryRawReader reader) { boolean loc = reader.readBoolean(); String txt = reader.readString(); String typ = reader.readString(); + final int limit = reader.readInt(); final int pageSize = reader.readInt(); - return new TextQuery(typ, txt).setPageSize(pageSize).setLocal(loc); + return new TextQuery(typ, txt, limit).setPageSize(pageSize).setLocal(loc); Review comment: Platforms do not support 'limit' param yet. So, attempt to read it can lead an error. Let's set a default value here and create a separate ticket for the issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services