From notifications-return-7154-archive-asf-public=cust-asf.ponee.io@ignite.apache.org  Thu Oct  3 10:05:59 2019
Return-Path: <notifications-return-7154-archive-asf-public=cust-asf.ponee.io@ignite.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 9AF38180675
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  3 Oct 2019 12:05:59 +0200 (CEST)
Received: (qmail 4694 invoked by uid 500); 3 Oct 2019 10:05:59 -0000
Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@ignite.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@ignite.apache.org>
List-Post: <mailto:notifications@ignite.apache.org>
List-Id: <notifications.ignite.apache.org>
Reply-To: dev@ignite.apache.org
Delivered-To: mailing list notifications@ignite.apache.org
Received: (qmail 4679 invoked by uid 99); 3 Oct 2019 10:05:59 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Oct 2019 10:05:59 +0000
From: GitBox <git@apache.org>
To: notifications@ignite.apache.org
Subject: [GitHub] [ignite] dgarus commented on a change in pull request #6923:
 IGNITE-12214: Continuous query system view.
Message-ID: <157009715894.1093.10809815543557522244.gitbox@gitbox.apache.org>
Date: Thu, 03 Oct 2019 10:05:58 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

dgarus commented on a change in pull request #6923: IGNITE-12214: Continuous query system view.
URL: https://github.com/apache/ignite/pull/6923#discussion_r330949911
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/continuous/GridContinuousProcessor.java
 ##########
 @@ -2056,13 +2098,16 @@ else if (log.isDebugEnabled())
         private boolean autoUnsubscribe;
 
         /**
+         * @param nodeId Node id.
          * @param prjPred Projection predicate.
          * @param hnd Continuous routine handler.
          * @param bufSize Buffer size.
          * @param interval Interval.
          * @param autoUnsubscribe Automatic unsubscribe flag.
          */
-        LocalRoutineInfo(@Nullable IgnitePredicate<ClusterNode> prjPred,
+        LocalRoutineInfo(
+            UUID nodeId,
 
 Review comment:
   Ok, I got it.
   But we can do a private build method like this
   ```
   private LocalRoutineInfo localRoutineInfo(@Nullable IgnitePredicate<ClusterNode> prjPred,
           GridContinuousHandler hnd,
           int bufSize,
           long interval,
           boolean autoUnsubscribe) {
           return new LocalRoutineInfo(
               ctx.localNodeId(),
               prjPred,
               hnd,
               bufSize,
               interval,
               autoUnsubscribe
           );
       }
   ```
   The main idea is an encapsulation of getting local node id.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services