ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6554: IGNITE-11073: Backup page store manager, initial
Date Thu, 31 Oct 2019 16:41:51 GMT
alex-plekhanov commented on a change in pull request #6554: IGNITE-11073: Backup page store
manager, initial
URL: https://github.com/apache/ignite/pull/6554#discussion_r338097554
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/file/FilePageStoreManager.java
 ##########
 @@ -743,6 +763,26 @@ private CacheStoreHolder initDir(File cacheWorkDir,
         return new File(cacheWorkDir, String.format(PART_FILE_TEMPLATE, partId)).toPath();
     }
 
+    /**
+     * @param workDir Cache work directory.
+     * @param cacheDirName Cache directory name.
+     * @param partId Partition id.
+     * @return Partition file.
+     */
+    @NotNull public static File getPartitionFileEx(File workDir, String cacheDirName, int
partId) {
 
 Review comment:
   `getPartitionFileEx` -> `getPartitionFile`
   `getPartitionNameEx` -> `getPartitionFileName`
   Reuse exisisting `getPartitionFile` in the new method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message