ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] pavlukhin commented on a change in pull request #6917: IGNITE-12189 Implementation correct limit for TextQuery
Date Wed, 30 Oct 2019 12:00:09 GMT
pavlukhin commented on a change in pull request #6917: IGNITE-12189 Implementation correct
limit for TextQuery
URL: https://github.com/apache/ignite/pull/6917#discussion_r340562521
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/query/GridQueryProcessor.java
 ##########
 @@ -2821,11 +2821,12 @@ public void remove(GridCacheContext cctx, CacheDataRow row)
      * @param filters Key and value filters.
      * @param <K> Key type.
      * @param <V> Value type.
+     * @param limit Limits response records count. If 0 or less, the limit considered to
be Integer.MAX_VALUE, that is virtually no limit.
 
 Review comment:
   Clarification is needed why it is no more than `Integer.MAX_VALUE`? Cannot we have more
with `GridCloseableIterator`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message