ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] dgarus commented on a change in pull request #6990: IGNITE-11992 The visor tasks lost permission.
Date Tue, 29 Oct 2019 07:36:43 GMT
dgarus commented on a change in pull request #6990: IGNITE-11992 The visor tasks lost permission.
URL: https://github.com/apache/ignite/pull/6990#discussion_r337384887
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/rest/GridRestProcessor.java
 ##########
 @@ -275,8 +275,10 @@
                     if (secCtx0 == null || ses.isTokenExpired(sesTokTtl))
                         ses.secCtx = secCtx0 = authenticate(req, ses);
 
-                    try(OperationSecurityContext s = ctx.security().withContext(secCtx0))
{
+                    try (OperationSecurityContext s = ctx.security().withContext(secCtx0))
{
                         authorize(req);
+
+                        return handle(req, true);
 
 Review comment:
   I think it's ok to call the handle method here, 
   but more readable would move the second call into else block.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message