ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] nizhikov commented on a change in pull request #6937: IGNITE-12186 TDE - Phase-2. Master key rotation.
Date Wed, 23 Oct 2019 14:23:27 GMT
nizhikov commented on a change in pull request #6937: IGNITE-12186 TDE - Phase-2. Master key
rotation.
URL: https://github.com/apache/ignite/pull/6937#discussion_r338080093
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/encryption/keystore/KeystoreEncryptionSpi.java
 ##########
 @@ -332,6 +302,22 @@ private void doEncryption(ByteBuffer data, Cipher cipher, Serializable
key, Byte
         return BLOCK_SZ;
     }
 
+    /** {@inheritDoc} */
+    @Override public String getMasterKeyId() {
 
 Review comment:
   Why do we need new method `getMasterKeyId` instead of `getMasterKeyName`?
   Let's keep existing method and not deprecate it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message