ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] nizhikov commented on a change in pull request #6937: IGNITE-12186 TDE - Phase-2. Master key rotation.
Date Wed, 23 Oct 2019 14:22:07 GMT
nizhikov commented on a change in pull request #6937: IGNITE-12186 TDE - Phase-2. Master key
rotation.
URL: https://github.com/apache/ignite/pull/6937#discussion_r338079236
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/encryption/keystore/KeystoreEncryptionSpi.java
 ##########
 @@ -113,24 +113,13 @@
      */
     private int keySize = DEFAULT_KEY_SIZE;
 
-    /**
-     * Master key name.
-     */
-    private String masterKeyName = DEFAULT_MASTER_KEY_NAME;
-
-    /**
-     * Master key.
-     */
-    private KeystoreEncryptionKey masterKey;
+    /** Tuple of the master key id and the master key. */
+    private volatile T2<String, KeystoreEncryptionKey> masterKey = new T2<>(DEFAULT_MASTER_KEY_NAME,
null);
 
 Review comment:
   Not clear to me.
   
   Why do we need volatile guarantees here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message