ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] shuliga commented on a change in pull request #6997: IGNITE-12189: Implement correct limit for TextQuery
Date Tue, 22 Oct 2019 20:10:49 GMT
shuliga commented on a change in pull request #6997: IGNITE-12189: Implement correct limit
for TextQuery
URL: https://github.com/apache/ignite/pull/6997#discussion_r337725832
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryFutureAdapter.java
 ##########
 @@ -57,6 +57,9 @@
     /** Logger reference. */
     private static final AtomicReference<IgniteLogger> logRef = new AtomicReference<>();
 
+    /** */
+    private static final int NO_LIMIT = -1;
 
 Review comment:
   This constant is not corresponding to original description in ticket https://issues.apache.org/jira/browse/IGNITE-12189
   >>> Special value: : 0 -> No limit (Integer.MAX_VALUE);
   
   We can proceed with this, then the dscription and all the correspondiing JavaDocs are needed
to be updated.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message