ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] ptupitsyn commented on a change in pull request #6490: IGNITE-7285 Add default query timeout
Date Tue, 22 Oct 2019 15:51:10 GMT
ptupitsyn commented on a change in pull request #6490: IGNITE-7285 Add default query timeout
URL: https://github.com/apache/ignite/pull/6490#discussion_r337601883
 
 

 ##########
 File path: modules/platforms/dotnet/Apache.Ignite.Core/IgniteConfiguration.cs
 ##########
 @@ -72,6 +72,11 @@ public class IgniteConfiguration
         /// </summary>
         public const int DefaultJvmMaxMem = -1;
 
+        /// <summary>
+        /// Default query timeout.
+        /// </summary>
+        public static readonly TimeSpan DefaultQueryTimeout = TimeSpan.FromMilliseconds(0);
 
 Review comment:
   Same name as the property below - won't compile. When the property is `X`, default value
for it is `DefaultX`, so in this case it would be `DefaultDefaultQueryTimeout`. But since
it is just `default(TimeSpan)`, I would remove it altogether.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message