ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] nizhikov commented on a change in pull request #6982: IGNITE-12295: Index partition purge for file-based rebalancing
Date Mon, 21 Oct 2019 12:26:05 GMT
nizhikov commented on a change in pull request #6982: IGNITE-12295: Index partition purge for
file-based rebalancing
URL: https://github.com/apache/ignite/pull/6982#discussion_r336986892
 
 

 ##########
 File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/database/H2TreeIndex.java
 ##########
 @@ -887,6 +890,32 @@ public GridH2RowMessage toSearchRowMessage(SearchRow row) {
         return res;
     }
 
+    /**
+     * Removes all index rows that belong to the specific data partitions.
+     *
+     * @param parts Partitions.
+     * @param shouldStop Allows to check stop condition.
+     */
+    public void purge(Set<Integer> parts, IgniteCallable<Boolean> shouldStop)
throws IgniteCheckedException {
+        if (F.isEmpty(parts))
 
 Review comment:
   We can't get here if `parts` is empty.
   Seems, we should replace this check with the assert.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message