ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] samaitra commented on issue #6490: IGNITE-7285 Add default query timeout
Date Sun, 20 Oct 2019 00:15:25 GMT
samaitra commented on issue #6490: IGNITE-7285 Add default query timeout
URL: https://github.com/apache/ignite/pull/6490#issuecomment-544208026
 
 
   > Additionally to comments for code lines there are some questions regarding testing
approach. Actually, I do not see how different are expectations from test with and without
configured default timeout. Basically, it is good to test following:
   > 
   > 1. Only default timeout specified -- query is cancelled after it, it is clear that
it was cancelled by timeout.
   > 2. Explicit timeout overrides default timeout.
   
   
   1. My understanding is in the method testQueryCancel when we are passing the 3rd argument
timeout as false then only default timeout is specified.
   2. When we are passing the 3rd argument timeout as true then explicit timeout overrides
default timeout.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message