ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] SomeFire commented on a change in pull request #6911: IGNITE-12232 NPE while node join processing
Date Thu, 17 Oct 2019 09:37:59 GMT
SomeFire commented on a change in pull request #6911: IGNITE-12232 NPE while node join processing
URL: https://github.com/apache/ignite/pull/6911#discussion_r335906434
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
 ##########
 @@ -2044,7 +2044,11 @@ private boolean recordable(TcpDiscoveryAbstractMessage msg) {
      * @param rmtPerms The second set of permissions.
      * @return {@code True} if given parameters contain the same permissions, {@code False}
otherwise.
      */
-    private boolean permissionsEqual(SecurityPermissionSet locPerms, SecurityPermissionSet
rmtPerms) {
+    private boolean permissionsEqual(@Nullable SecurityPermissionSet locPerms,
+        @Nullable SecurityPermissionSet rmtPerms) {
+        if (locPerms == null || rmtPerms == null)
 
 Review comment:
   Both nulls means something wrong with configuration because it shouldn't be possible, because
Ignite checks configuration consistency.
   
   `null` `rmtPerms` means authenticator on current node doesn't authenticated node.
   `null` `locPerms` means authenticator on joining node doesn't authenticated node. In this
case node shouldn't start because of `null` in `localAuthentication`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message