ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6911: IGNITE-12232 NPE while node join processing
Date Thu, 17 Oct 2019 07:58:55 GMT
alex-plekhanov commented on a change in pull request #6911: IGNITE-12232 NPE while node join
processing
URL: https://github.com/apache/ignite/pull/6911#discussion_r335858902
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
 ##########
 @@ -4737,7 +4741,7 @@ else if (!locNodeId.equals(node.id()) && ring.node(node.id())
!= null) {
                                 spi.marshaller(), U.resolveClassLoader(spi.ignite().configuration()),
node
                             );
 
-                            if (!permissionsEqual(coordSubj.subject().permissions(), subj.subject().permissions()))
{
+                            if (!permissionsEqual(getPermissions(coordSubj), getPermissions(subj)))
{
 
 Review comment:
   Where is that check? I see only usage of the same method `nodeSecurityContext` to get `coordSubj`
and no null check after it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message