ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] dmagda commented on a change in pull request #6976: IGNITE-6804 Warning if unordered map used in locking cache operation.
Date Wed, 16 Oct 2019 23:47:12 GMT
dmagda commented on a change in pull request #6976: IGNITE-6804 Warning if unordered map used
in locking cache operation.
URL: https://github.com/apache/ignite/pull/6976#discussion_r335755922
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/IgniteCache.java
 ##########
 @@ -639,6 +639,10 @@
      * <p>
      * Please refer to documentation for {@link CacheAtomicityMode#ATOMIC} for information
on
      * system behavior in crash scenarios for atomic caches.
+     * <p>
 
 Review comment:
   Ilya, how about this version? I would use it here and in similar places below.
   
   _Note, always pass the keys in ordered maps like TreeMap to avoid distributed deadlocks.
Ignite always locks/accesses the keys in a way they ordered within a data structure. Don't
use unordered maps like HashMap to avoid distributed deadlocks that happen if this or similar
method is called by multiple threads/applications and keys are passed in an unordered map._

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message