ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] anton-vinogradov commented on a change in pull request #6942: IGNITE-9913
Date Tue, 15 Oct 2019 06:44:26 GMT
anton-vinogradov commented on a change in pull request #6942: IGNITE-9913
URL: https://github.com/apache/ignite/pull/6942#discussion_r334774965
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java
 ##########
 @@ -3826,10 +3952,14 @@ private void assignPartitionsStates() {
     }
 
     /**
-     * Removes gaps in the local update counters. Gaps in update counters are possible on
backup node when primary
-     * failed to send update counter deltas to backup.
+     * Removes gaps in the local update counters. Affects specified node's primary partitions
in case node specified and
+     * all local partitins otherwise.
+     *
+     * Gaps in update counters are possible on backup node when primary failed to send update
counter deltas to backup.
+     *
+     * @param nodeId Failed node id, {@code null} in case of merged failures.
      */
-    private void finalizePartitionCounters() {
+    private void finalizePartitionCounters(UUID nodeId) {
 
 Review comment:
   Not sure I understand who checks them... and how?
   What contract we have here, what difference with absent annotation?
   Seems, that's a holywar issue :)
   Will you mind if I keep this as is?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message