ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] anton-vinogradov commented on a change in pull request #6942: IGNITE-9913
Date Thu, 10 Oct 2019 08:31:55 GMT
anton-vinogradov commented on a change in pull request #6942: IGNITE-9913
URL: https://github.com/apache/ignite/pull/6942#discussion_r333391359
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java
 ##########
 @@ -1021,6 +1025,15 @@ private boolean isLocalNodeInBaseline() {
         return topology != null && topology.consistentIds().contains(cctx.localNode().consistentId());
     }
 
+    /**
+     * @return {@code true} if Event node is in baseline and {@code false} otherwise.
+     */
+    public boolean isEventNodeInBaseline() {
+        BaselineTopology top = cctx.discovery().discoCache().state().baselineTopology();
+
+        return top != null && top.consistentIds().contains(firstDiscoEvt.eventNode().consistentId());
+    }
 
 Review comment:
   1) Correct fix is to use versioned disco? 
   `cctx.discovery().discoCache(topVer)...` correct?
   
   2) We never merge left with anything 
   `if (baselineNodeLeft) baselineNodeLeft = true;
   merge = false;`
   so, even cascade failure will be processed one-by-one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message