ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] Jokser commented on a change in pull request #6942: IGNITE-9913
Date Wed, 09 Oct 2019 15:33:38 GMT
Jokser commented on a change in pull request #6942: IGNITE-9913
URL: https://github.com/apache/ignite/pull/6942#discussion_r333084702
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionsExchangeFuture.java
 ##########
 @@ -1628,6 +1660,100 @@ private void changeWalModeIfNeeded() {
         return null;
     }
 
+    /**
+     * @throws IgniteCheckedException If failed.
+     */
+    private void waitRecovery() throws IgniteCheckedException {
 
 Review comment:
   I see no tests in PR :(.
   The following 2 cases need to be tested explicitly (to make sure that your optimization
works correctly):
   Case 1:
   1. Create a transaction that contains a primary partition that belongs to the left node.
   2. Make sure that the transaction is prepared on primary and backups and then block the
finish request to backup.
   3. Make sure that new transactions can be started and committed on nodes that don't contain
affected partitions
   4. Make sure that new transactions are blocked on nodes that contain affected partitions.
   5. Unblock finish request messages.
   6. Make sure that transactions waiting for local recovery are committed and PME on corresponding
nodes finished.
   7. Make sure that new transactions are unblocked and committed on nodes where PME is finished.
   
   
   Case 2:
   1. Create a transaction that contains a primary partition that belongs to the left node.
   2. Make sure that the transaction is prepared on primary and backups and then block the
finish request to backup.
   3. Kill node, make sure that transaction recovery is started and then block recovery messages.
   4. Make sure that PME on node left is finished on nodes that don't contain affected partitions.
   5. Make sure that new transactions can be started and committed on nodes that don't contain
affected partitions
   6. Make sure that new transactions are blocked on nodes that contain affected partitions.
   7. Unblock recovery messages.
   8. Make sure that transactions are recovered and committed and PME on corresponding nodes
finished.
   9. Make sure that new transactions are unblocked and committed on nodes where PME is finished.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message