ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] dgarus commented on a change in pull request #6927: IGNITE-12212: Cluster nodes system view.
Date Wed, 09 Oct 2019 08:31:17 GMT
dgarus commented on a change in pull request #6927: IGNITE-12212: Cluster nodes system view.
URL: https://github.com/apache/ignite/pull/6927#discussion_r332865183
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/managers/systemview/SystemViewAdapter.java
 ##########
 @@ -70,20 +74,49 @@ public SystemViewAdapter(String name, String desc, Class<R> rowCls,
         this.walker = walker;
 
         this.data = data;
+        this.dataSupplier = null;
+        this.rowFunc = rowFunc;
+    }
+
+    /**
+     * @param name Name.
+     * @param desc Description.
+     * @param rowCls Row class.
+     * @param walker Walker.
+     * @param dataSupplier Data supplier.
+     * @param rowFunc Row function.
+     */
+    public SystemViewAdapter(String name, String desc, Class<R> rowCls,
 
 Review comment:
   Too many constructor arguments.
   Maybe we should use the builder pattern?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message