ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] AMashenkov commented on a change in pull request #6917: IGNITE-12189 Implementation correct limit for TextQuery
Date Fri, 04 Oct 2019 15:10:06 GMT
AMashenkov commented on a change in pull request #6917: IGNITE-12189 Implementation correct
limit for TextQuery
URL: https://github.com/apache/ignite/pull/6917#discussion_r331551796
 
 

 ##########
 File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/GridCacheFullTextQuerySelfTest.java
 ##########
 @@ -59,6 +59,19 @@
     /** Cache name */
     private static final String PERSON_CACHE = "Person";
 
+    /** Limitation to query response size */
+    private static final int QUERY_LIMIT = 5;
+
+    private static final class TestPair{
+
+        public final Set<Integer> expected;
+        public final List<Cache.Entry<Integer, ?>> all = new ArrayList<>();
+
+        public TestPair(Set<Integer> exp) {
+            this.expected = new HashSet<>(exp);
+        }
+    }
 
 Review comment:
   This class also should have minimal javadoc.
   
   https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-JavadocComments
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message