ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] AMashenkov commented on a change in pull request #6917: IGNITE-12189 Implementation correct limit for TextQuery
Date Thu, 03 Oct 2019 14:37:20 GMT
AMashenkov commented on a change in pull request #6917: IGNITE-12189 Implementation correct
limit for TextQuery
URL: https://github.com/apache/ignite/pull/6917#discussion_r331070480
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/platform/cache/PlatformCache.java
 ##########
 @@ -1420,9 +1420,10 @@ private Query readTextQuery(BinaryRawReader reader) {
         boolean loc = reader.readBoolean();
         String txt = reader.readString();
         String typ = reader.readString();
+        final int limit = reader.readInt();
         final int pageSize = reader.readInt();
 
-        return new TextQuery(typ, txt).setPageSize(pageSize).setLocal(loc);
+        return new TextQuery(typ, txt, limit).setPageSize(pageSize).setLocal(loc);
 
 Review comment:
   Platforms do not support 'limit' param yet. 
   So, attempt to read it can lead an error. 
   
   Let's set a default value here and create a separate ticket for the issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message