ignite-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [ignite] dgarus commented on a change in pull request #6923: IGNITE-12214: Continuous query system view.
Date Thu, 03 Oct 2019 10:05:58 GMT
dgarus commented on a change in pull request #6923: IGNITE-12214: Continuous query system view.
URL: https://github.com/apache/ignite/pull/6923#discussion_r330949911
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/continuous/GridContinuousProcessor.java
 ##########
 @@ -2056,13 +2098,16 @@ else if (log.isDebugEnabled())
         private boolean autoUnsubscribe;
 
         /**
+         * @param nodeId Node id.
          * @param prjPred Projection predicate.
          * @param hnd Continuous routine handler.
          * @param bufSize Buffer size.
          * @param interval Interval.
          * @param autoUnsubscribe Automatic unsubscribe flag.
          */
-        LocalRoutineInfo(@Nullable IgnitePredicate<ClusterNode> prjPred,
+        LocalRoutineInfo(
+            UUID nodeId,
 
 Review comment:
   Ok, I got it.
   But we can do a private build method like this
   ```
   private LocalRoutineInfo localRoutineInfo(@Nullable IgnitePredicate<ClusterNode>
prjPred,
           GridContinuousHandler hnd,
           int bufSize,
           long interval,
           boolean autoUnsubscribe) {
           return new LocalRoutineInfo(
               ctx.localNodeId(),
               prjPred,
               hnd,
               bufSize,
               interval,
               autoUnsubscribe
           );
       }
   ```
   The main idea is an encapsulation of getting local node id.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message