From notifications-return-7038-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Thu Sep 26 09:12:44 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id CD96F1804BB for ; Thu, 26 Sep 2019 11:12:43 +0200 (CEST) Received: (qmail 23589 invoked by uid 500); 26 Sep 2019 09:12:39 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 23526 invoked by uid 99); 26 Sep 2019 09:12:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Sep 2019 09:12:39 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] zaleslaw commented on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame) Message-ID: <156948915924.31904.5644293526927981655.gitbox@gitbox.apache.org> Date: Thu, 26 Sep 2019 09:12:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit zaleslaw commented on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame) URL: https://github.com/apache/ignite/pull/6907#issuecomment-535415057 About formatting, I use codestyle for two years the same like for other components, ok, I'll revert the formatting, but could you share please the link or file with codestyle (maybe somebody used outdated) and this is an issue. About test - I thought, it's not to easy to emulate because but I'll try ср, 25 сент. 2019 г. в 22:59, Nikolay : > @zaleslaw > > Overall looks good. > > 1. > > Seems your IDE code format changes differ from Ignite one. There is > some nits in patch. Please, revert unnecessary changes. > 2. > > Can we add the test for a new property? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , > or mute the thread > > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services