From notifications-return-7035-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Sep 25 19:59:34 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1FF64180637 for ; Wed, 25 Sep 2019 21:59:34 +0200 (CEST) Received: (qmail 30021 invoked by uid 500); 25 Sep 2019 19:59:33 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 30009 invoked by uid 99); 25 Sep 2019 19:59:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Sep 2019 19:59:33 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] nizhikov edited a comment on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame) Message-ID: <156944157345.19036.1259993301173232360.gitbox@gitbox.apache.org> Date: Wed, 25 Sep 2019 19:59:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nizhikov edited a comment on issue #6907: IGNITE-11723: IgniteSpark integration should support skipStore option for internal dataStreamer (IgniteRdd and Ignite DataFrame) URL: https://github.com/apache/ignite/pull/6907#issuecomment-535187356 @zaleslaw Overall looks good. 1. Seems your IDE code format differ from Ignite one. There are some nits in the patch. Please, revert unnecessary changes. 2. Can we add the test for a new property? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services