From notifications-return-7006-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Sep 24 16:05:11 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8E4B3180644 for ; Tue, 24 Sep 2019 18:05:11 +0200 (CEST) Received: (qmail 92311 invoked by uid 500); 24 Sep 2019 16:05:11 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 92302 invoked by uid 99); 24 Sep 2019 16:05:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Sep 2019 16:05:10 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] nizhikov commented on a change in pull request #6898: IGNITE-12211: Client connections system view Message-ID: <156934111090.8675.6472831713850982142.gitbox@gitbox.apache.org> Date: Tue, 24 Sep 2019 16:05:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nizhikov commented on a change in pull request #6898: IGNITE-12211: Client connections system view URL: https://github.com/apache/ignite/pull/6898#discussion_r327703085 ########## File path: modules/core/src/test/java/org/apache/ignite/internal/metric/JmxExporterSpiTest.java ########## @@ -62,6 +69,9 @@ import static org.apache.ignite.internal.processors.metric.GridMetricManager.GC_CPU_LOAD_DESCRIPTION; import static org.apache.ignite.internal.processors.metric.GridMetricManager.SYS_METRICS; import static org.apache.ignite.internal.processors.metric.impl.MetricUtils.metricName; +import static org.apache.ignite.internal.processors.odbc.ClientListenerProcessor.CLI_CONN_SYS_VIEW; +import static org.apache.ignite.internal.processors.odbc.jdbc.JdbcConnectionContext.CURRENT_VER; +import static org.apache.ignite.internal.processors.platform.client.ClientConnectionContext.DEFAULT_VER; Review comment: The client from the same source will have same version, isn't it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services