From notifications-return-6877-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Tue Sep 17 15:50:41 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EBAD5180645 for ; Tue, 17 Sep 2019 17:50:40 +0200 (CEST) Received: (qmail 44002 invoked by uid 500); 17 Sep 2019 15:50:40 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 43993 invoked by uid 99); 17 Sep 2019 15:50:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Sep 2019 15:50:40 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine. Message-ID: <156873544036.1521.14454212540522135635.gitbox@gitbox.apache.org> Date: Tue, 17 Sep 2019 15:50:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine. URL: https://github.com/apache/ignite/pull/6845#discussion_r325248288 ########## File path: modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcMetadataSelfTest.java ########## @@ -320,10 +319,8 @@ public void testGetTableTypes() throws Exception { */ @Test public void testGetAllView() throws Exception { - List expViews = Arrays.asList( + Set expViews = new HashSet<>(Arrays.asList( "BASELINE_NODES", - "CACHES", - "CACHE_GROUPS", Review comment: Wouldn't it be better to have enabled system view by default? To enable views admin must restart the node, sometimes it's not a good issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services