From notifications-return-6855-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Sep 16 13:34:19 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2D2BF180638 for ; Mon, 16 Sep 2019 15:34:19 +0200 (CEST) Received: (qmail 28216 invoked by uid 500); 16 Sep 2019 13:34:18 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 28206 invoked by uid 99); 16 Sep 2019 13:34:18 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Sep 2019 13:34:18 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] ibessonov commented on a change in pull request #6814: IGNITE-12108 TCP Communication Metrics ported to a new framework. Message-ID: <156864085846.26586.2995376224811943908.gitbox@gitbox.apache.org> Date: Mon, 16 Sep 2019 13:34:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ibessonov commented on a change in pull request #6814: IGNITE-12108 TCP Communication Metrics ported to a new framework. URL: https://github.com/apache/ignite/pull/6814#discussion_r324677493 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/util/nio/GridAbstractCommunicationClient.java ########## @@ -32,19 +39,27 @@ /** Reservations. */ private final AtomicBoolean closed = new AtomicBoolean(); - /** Metrics listener. */ - protected final GridNioMetricsListener metricsLsnr; - /** */ private final int connIdx; + /** Received bytes count metric. */ + @Nullable protected final LongAdderMetric rcvdBytesCntMetric; + + /** Sent bytes count metric. */ + @Nullable protected final LongAdderMetric sentBytesCntMetric; + /** * @param connIdx Connection index. - * @param metricsLsnr Metrics listener. + * @param mreg Metrics registry. */ - protected GridAbstractCommunicationClient(int connIdx, @Nullable GridNioMetricsListener metricsLsnr) { + protected GridAbstractCommunicationClient(int connIdx, @Nullable MetricRegistry mreg) { Review comment: This class might be used by components other than TCP SPI. You can see that "GridNioMetricsListener" was nullable as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services