From notifications-return-6850-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Sep 16 12:04:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 25E9B180638 for ; Mon, 16 Sep 2019 14:04:20 +0200 (CEST) Received: (qmail 36466 invoked by uid 500); 16 Sep 2019 12:04:19 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 36457 invoked by uid 99); 16 Sep 2019 12:04:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Sep 2019 12:04:19 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] nizhikov commented on a change in pull request #6738: IGNITE-12027 NPE on try to read the MinimumNumberOfPartitionCopies metric. Message-ID: <156863545945.4400.12175098139102306151.gitbox@gitbox.apache.org> Date: Mon, 16 Sep 2019 12:04:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nizhikov commented on a change in pull request #6738: IGNITE-12027 NPE on try to read the MinimumNumberOfPartitionCopies metric. URL: https://github.com/apache/ignite/pull/6738#discussion_r324635651 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupMetricsImpl.java ########## @@ -59,6 +60,12 @@ /** */ private final LongAdderMetric groupPageAllocationTracker; + /** */ + private volatile LongMetric storageSize; Review comment: Why this variable is volatile? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services