From notifications-return-6720-archive-asf-public=cust-asf.ponee.io@ignite.apache.org  Wed Sep 11 14:42:46 2019
Return-Path: <notifications-return-6720-archive-asf-public=cust-asf.ponee.io@ignite.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 0D36018063F
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 11 Sep 2019 16:42:45 +0200 (CEST)
Received: (qmail 29679 invoked by uid 500); 11 Sep 2019 14:42:45 -0000
Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@ignite.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@ignite.apache.org>
List-Post: <mailto:notifications@ignite.apache.org>
List-Id: <notifications.ignite.apache.org>
Reply-To: dev@ignite.apache.org
Delivered-To: mailing list notifications@ignite.apache.org
Received: (qmail 29667 invoked by uid 99); 11 Sep 2019 14:42:45 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Sep 2019 14:42:45 +0000
From: GitBox <git@apache.org>
To: notifications@ignite.apache.org
Subject: [GitHub] [ignite] alex-plekhanov commented on a change in pull request
 #6845: IGNITE-12145: Monitoring list engine.
Message-ID: <156821296538.26058.13330073482462066054.gitbox@gitbox.apache.org>
Date: Wed, 11 Sep 2019 14:42:45 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

alex-plekhanov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
URL: https://github.com/apache/ignite/pull/6845#discussion_r323282217
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/metric/GridMetricManager.java
 ##########
 @@ -265,45 +378,116 @@ public MetricRegistry registry(String name) {
         return registries.computeIfAbsent(name, n -> {
             MetricRegistry mreg = new MetricRegistry(name, log);
 
-            notifyListeners(mreg, metricRegCreationLsnrs);
+            notifyListeners(mreg, metricRegCreationLsnrs, log);
 
             return mreg;
         });
     }
 
-    /** {@inheritDoc} */
-    @NotNull @Override public Iterator<MetricRegistry> iterator() {
-        return registries.values().iterator();
+    public <R extends MonitoringRow, D> void list(String name, String description,
+        Class<R> rowClazz, Supplier<ConcurrentMap<?, D>> data, Function<D, R> rowFunc, Consumer<D> clearer) {
+
+        Supplier<MonitoringList<R>> listCreator = () -> list(name, () -> new MonitoringListAdapter<>(name,
+            description,
+            rowClazz,
+            (MonitoringRowAttributeWalker<R>)walkers.get(rowClazz),
+            data.get(),
+            rowFunc));
+
+        //Create new instance of the list.
 
 Review comment:
   Space missed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services