From notifications-return-6713-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Sep 11 14:22:51 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BA9BA18063F for ; Wed, 11 Sep 2019 16:22:50 +0200 (CEST) Received: (qmail 65516 invoked by uid 500); 11 Sep 2019 14:22:50 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 65504 invoked by uid 99); 11 Sep 2019 14:22:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Sep 2019 14:22:50 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] nizhikov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine. Message-ID: <156821177009.14357.2244669803888672938.gitbox@gitbox.apache.org> Date: Wed, 11 Sep 2019 14:22:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nizhikov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine. URL: https://github.com/apache/ignite/pull/6845#discussion_r323270197 ########## File path: modules/codegen/src/main/java/org/apache/ignite/codegen/MonitoringRowAttributeWalkerGenerator.java ########## @@ -0,0 +1,289 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.codegen; + +import java.io.File; +import java.io.FileWriter; +import java.io.IOException; +import java.lang.reflect.Method; +import java.lang.reflect.Modifier; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collection; +import java.util.Collections; +import java.util.Comparator; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import java.util.TreeSet; +import java.util.function.ObjIntConsumer; +import org.apache.ignite.internal.processors.metric.list.walker.Order; +import org.apache.ignite.spi.metric.jmx.MonitoringListMBean; +import org.apache.ignite.spi.metric.list.MonitoringList; +import org.apache.ignite.spi.metric.list.MonitoringRow; +import org.apache.ignite.spi.metric.list.MonitoringRowAttributeWalker; +import org.apache.ignite.spi.metric.list.view.CacheGroupView; +import org.apache.ignite.spi.metric.list.view.CacheView; +import org.apache.ignite.spi.metric.list.view.ComputeTaskView; +import org.apache.ignite.spi.metric.list.view.ServiceView; +import org.apache.ignite.spi.metric.sql.MonitoringListLocalSystemView; + +import static org.apache.ignite.codegen.MessageCodeGenerator.DFLT_SRC_DIR; Review comment: Why it should be independent? Constants created to be resused, istn't it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services