From notifications-return-6701-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Sep 11 14:05:51 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BDBE418063F for ; Wed, 11 Sep 2019 16:05:50 +0200 (CEST) Received: (qmail 14671 invoked by uid 500); 11 Sep 2019 14:05:50 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 14662 invoked by uid 99); 11 Sep 2019 14:05:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Sep 2019 14:05:50 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] nizhikov commented on a change in pull request #6814: IGNITE-12108 TCP Communication Metrics ported to a new framework. Message-ID: <156821075002.3345.11965825209708852023.gitbox@gitbox.apache.org> Date: Wed, 11 Sep 2019 14:05:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nizhikov commented on a change in pull request #6814: IGNITE-12108 TCP Communication Metrics ported to a new framework. URL: https://github.com/apache/ignite/pull/6814#discussion_r323260979 ########## File path: modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java ########## @@ -403,6 +401,50 @@ /** Handshake wait message type. */ public static final short HANDSHAKE_WAIT_MSG_TYPE = -28; + /** Communication metrics group name. */ + public static final String COMMUNICATION_METRICS_GROUP_NAME = "communication.tcp"; + + /** */ + public static final String SENT_MESSAGES_METRIC_NAME = "sentMessagesCount"; + + /** */ + public static final String SENT_MESSAGES_METRIC_DESC = "Total number of messages sent by current node"; + + /** */ + public static final String RECEIVED_MESSAGES_METRIC_NAME = "receivedMessagesCount"; + + /** */ + public static final String RECEIVED_MESSAGES_METRIC_DESC = "Total number of messages received by current node"; + + + /** */ + public static String sentMessagesByTypeMetricName(Short directType) { Review comment: Let's declare all constants, first, and methods after. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services