From notifications-return-6687-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Sep 11 12:30:58 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5B22C18063F for ; Wed, 11 Sep 2019 14:30:58 +0200 (CEST) Received: (qmail 31723 invoked by uid 500); 11 Sep 2019 12:30:57 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 31714 invoked by uid 99); 11 Sep 2019 12:30:57 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Sep 2019 12:30:57 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] nizhikov commented on a change in pull request #6737: IGNITE-11944 [IEP-35] OpencensusExporter should export Histogram metrics Message-ID: <156820505768.8212.6910650604704393713.gitbox@gitbox.apache.org> Date: Wed, 11 Sep 2019 12:30:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nizhikov commented on a change in pull request #6737: IGNITE-11944 [IEP-35] OpencensusExporter should export Histogram metrics URL: https://github.com/apache/ignite/pull/6737#discussion_r323213084 ########## File path: modules/opencensus/src/main/java/org/apache/ignite/spi/metric/opencensus/OpenCensusMetricExporterSpi.java ########## @@ -118,6 +120,26 @@ */ private Map measures = new HashMap<>(); + /** Cached histogram metrics intervals names. */ + private Map, String[]> histogramNames = new HashMap<>(); Review comment: Seems, a map is not cleared on `MetricRegistry` remove. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services