From notifications-return-6681-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Wed Sep 11 09:47:51 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AC6B218063F for ; Wed, 11 Sep 2019 11:47:50 +0200 (CEST) Received: (qmail 4679 invoked by uid 500); 11 Sep 2019 09:47:50 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 4670 invoked by uid 99); 11 Sep 2019 09:47:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Sep 2019 09:47:50 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] zaleslaw commented on a change in pull request #6857: IGNITE-12155: [ML] Implementation of distributed estimator Message-ID: <156819526990.10776.3616618490396648335.gitbox@gitbox.apache.org> Date: Wed, 11 Sep 2019 09:47:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit zaleslaw commented on a change in pull request #6857: IGNITE-12155: [ML] Implementation of distributed estimator URL: https://github.com/apache/ignite/pull/6857#discussion_r323152749 ########## File path: modules/ml/src/main/java/org/apache/ignite/ml/selection/scoring/evaluator/Evaluator.java ########## @@ -41,358 +56,585 @@ /** * Computes the given metric on the given cache. * - * @param dataCache The given cache. - * @param mdl The model. + * @param dataCache The given cache. + * @param mdl The model. * @param preprocessor The preprocessor. - * @param metric The binary classification metric. - * @param The type of cache entry key. - * @param The type of cache entry value. + * @param metric The metric. + * @param The type of cache entry key. + * @param The type of cache entry value. * @return Computed metric. */ - public static double evaluate(IgniteCache dataCache, Review comment: Use Ignite codestyle for formatting ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services