From notifications-return-6645-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Sep 9 20:44:28 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2E617180652 for ; Mon, 9 Sep 2019 22:44:28 +0200 (CEST) Received: (qmail 3714 invoked by uid 500); 9 Sep 2019 20:44:27 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 3704 invoked by uid 99); 9 Sep 2019 20:44:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Sep 2019 20:44:27 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] daradurvs commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine. Message-ID: <156806186743.24843.12456803185544617730.gitbox@gitbox.apache.org> Date: Mon, 09 Sep 2019 20:44:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit daradurvs commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine. URL: https://github.com/apache/ignite/pull/6845#discussion_r322414228 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ClusterCachesInfo.java ########## @@ -106,9 +118,25 @@ /** Dynamic caches. */ private final ConcurrentMap registeredCaches = new ConcurrentHashMap<>(); + /** + * Monitoring list for caches. + * + * @see ReadOnlyMonitoringListRegistry + * @see GridMetricManager + */ + @Nullable private volatile MonitoringListImpl cachesMonList; + /** */ private final ConcurrentMap registeredCacheGrps = new ConcurrentHashMap<>(); + /** + * Monitoring list for cache groups. + * + * @see ReadOnlyMonitoringListRegistry + * @see GridMetricManager + */ + @Nullable private volatile MonitoringListImpl cachesGrpMonList; Review comment: volatile is not required - as far as I can see, the field will be processed only by discovery thread ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services