From notifications-return-6595-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Sun Sep 8 08:50:53 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9AB0D18067A for ; Sun, 8 Sep 2019 10:50:52 +0200 (CEST) Received: (qmail 86437 invoked by uid 500); 8 Sep 2019 08:50:54 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 86282 invoked by uid 99); 8 Sep 2019 08:50:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Sep 2019 08:50:53 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] nizhikov commented on a change in pull request #6837: IGNITE-10223: affinity list methods are added, tests are changed Message-ID: <156793265175.15587.17505025291502081544.gitbox@gitbox.apache.org> Date: Sun, 08 Sep 2019 08:50:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nizhikov commented on a change in pull request #6837: IGNITE-10223: affinity list methods are added, tests are changed URL: https://github.com/apache/ignite/pull/6837#discussion_r321997741 ########## File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/affinity/GridCacheAffinityImpl.java ########## @@ -218,20 +219,40 @@ public GridCacheAffinityImpl(GridCacheContext cctx) { return res; } - /** {@inheritDoc} */ + /** @deprecated Use mapKeyToPrimaryAndBackupsList(K) instead */ + @Deprecated @Override public Collection mapKeyToPrimaryAndBackups(K key) { A.notNull(key, "key"); return cctx.affinity().nodesByPartition(partition(key), topologyVersion()); } /** {@inheritDoc} */ + @Override + public List mapKeyToPrimaryAndBackupsList(K key) { Review comment: Please, write it in one line: `@Override public` Any reason to copy-paste implementation from `mapKeyToPrimaryAndBackupsList`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services