From notifications-return-6541-archive-asf-public=cust-asf.ponee.io@ignite.apache.org Mon Sep 2 12:43:21 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6A08A180658 for ; Mon, 2 Sep 2019 14:43:21 +0200 (CEST) Received: (qmail 57216 invoked by uid 500); 2 Sep 2019 13:40:25 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 57205 invoked by uid 99); 2 Sep 2019 13:40:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Sep 2019 13:40:25 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] SomeFire commented on a change in pull request #6799: IGNITE-11094 Add SSL support for ignite zookeeper SPI Message-ID: <156742820077.24943.819093801221021237.gitbox@gitbox.apache.org> Date: Mon, 02 Sep 2019 12:43:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit SomeFire commented on a change in pull request #6799: IGNITE-11094 Add SSL support for ignite zookeeper SPI URL: https://github.com/apache/ignite/pull/6799#discussion_r319942380 ########## File path: modules/zookeeper/src/test/java/org/apache/ignite/spi/discovery/tcp/ipfinder/zk/curator/TestingZooKeeperServer.java ########## @@ -30,11 +31,15 @@ import java.io.Closeable; import java.io.IOException; import java.util.Collection; +import java.util.Properties; import java.util.concurrent.atomic.AtomicReference; /** */ public class TestingZooKeeperServer extends QuorumPeerMain implements Closeable { + /** */ + public static final String SECURITY_CLIENT_PORT = "secureClientPort"; Review comment: There is no such link in zookeeper project. String is hardcoded. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services