From notifications-return-6688-apmail-ignite-notifications-archive=ignite.apache.org@ignite.apache.org Wed Sep 11 12:32:43 2019 Return-Path: X-Original-To: apmail-ignite-notifications-archive@minotaur.apache.org Delivered-To: apmail-ignite-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id F0C4E19F3E for ; Wed, 11 Sep 2019 12:32:42 +0000 (UTC) Received: (qmail 32986 invoked by uid 500); 11 Sep 2019 12:32:42 -0000 Delivered-To: apmail-ignite-notifications-archive@ignite.apache.org Received: (qmail 32969 invoked by uid 500); 11 Sep 2019 12:32:42 -0000 Mailing-List: contact notifications-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list notifications@ignite.apache.org Received: (qmail 32948 invoked by uid 99); 11 Sep 2019 12:32:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Sep 2019 12:32:42 +0000 From: GitBox To: notifications@ignite.apache.org Subject: [GitHub] [ignite] nizhikov commented on a change in pull request #6737: IGNITE-11944 [IEP-35] OpencensusExporter should export Histogram metrics Message-ID: <156820516233.9190.15963713859951070537.gitbox@gitbox.apache.org> Date: Wed, 11 Sep 2019 12:32:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nizhikov commented on a change in pull request #6737: IGNITE-11944 [IEP-35] OpencensusExporter should export Histogram metrics URL: https://github.com/apache/ignite/pull/6737#discussion_r323213840 ########## File path: modules/opencensus/src/main/java/org/apache/ignite/spi/metric/opencensus/OpenCensusMetricExporterSpi.java ########## @@ -183,6 +205,36 @@ else if (metric instanceof DoubleMetric) { mmap.put(msr, val); } + else if (metric instanceof HistogramMetric) { + /* + Histogram exports as a separate long metric for each interval. + Example of metric names if bounds are 10,100: + histogram_0_10 (less than 10) + histogram_10_100 (between 10 and 100) + histogram_100_inf (more than 100) + */ + long[] value = ((HistogramMetric)metric).value(); Review comment: A variable should named `values`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services